Clean JS for every Atoms #699
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
williambelle
commented
Dec 1, 2023
williambelle
commented
- Fix eslint warnings and errors
- Fix deprecated jQuery API
- Fix eslint warnings and errors - Fix deprecated jQuery API
./node_modules/.bin/eslint assets/components/atoms
elements/assets/components/atoms/drawer/drawer.js
4:29 warning Unexpected unnamed function func-names
elements/assets/components/atoms/popover/popover.js
4:5 error Unexpected function expression prefer-arrow-callback
4:5 warning Unexpected unnamed function func-names
13:1 error Too many blank lines at the end of file. Max of 0 allowed no-multiple-empty-lines
elements/assets/components/atoms/tag/tag-input.js
9:13 error Expected parentheses around arrow function argument arrow-parens
elements/assets/components/atoms/upload/upload.js
4:48 warning Unexpected unnamed function func-names
9:13 error Use object destructuring prefer-destructuring
13:55 error Expected parentheses around arrow function argument arrow-parens
20:1 error Too many blank lines at the end of file. Max of 0 allowed no-multiple-empty-lines
✖ 9 problems (6 errors, 3 warnings)
6 errors and 0 warnings potentially fixable with the `--fix` option. |
|
🔎 Download the Backstop report for this pull request (link valid for 90 days): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.